× Bug reports for the Retail version of Healbot

Some non-healing abilities not working after spec change

4 months 15 hours ago
Strife
Administrator
Administrator
Posts: 718
Karma: 8
More
Some non-healing abilities not working after spec change #1512
Still can't replicate this, in beta 6 (will be uploaded soon) even if the tank is in combat and I have autoCombat turned on, as long as I am out of combat the spells all work after a spec change.
beta 6 does have more changes to get the whole process to near instant.
This is what I have been doing on a Preist

1) Switch to shadow
2) Queue for random dungeon as healer
3) Enter random as shadow
4) watch the tank go into combat, not once has the tank ask why im shadow
5) Change to Holy
6) Enter combat due to healing

Generally there is near no time between steps, not had any issues with spells due to spec change while in a group

Please Log in or Create an account to join the conversation.

4 months 15 hours ago
ctshammy
Moderator
Moderator
Posts: 104
More
Some non-healing abilities not working after spec change #1514
When this happens to me I find a reloadui always fixes the issue.

CT

Please Log in or Create an account to join the conversation.

3 months 4 weeks ago
Strife
Administrator
Administrator
Posts: 718
Karma: 8
More
Some non-healing abilities not working after spec change #1518
Beta 7 is my last attempt to fix this in 8.2.0.3, try it and see. A number of minor bugs have been fixed and it kinda works in classic, so want to release this version.

Please Log in or Create an account to join the conversation.

3 months 4 weeks ago
Slayybelle
Regular Member
Regular Member
Posts: 31
More
Topic Author
Some non-healing abilities not working after spec change #1523
BIG CLUE?

TLDR: moving logic for HealBot_Options_Timer[35] to end of elseif list fixes the problem.

HealBot_Options_Update is a string of elseif statements so the first true condition is executed to the exclusion of the others. In this case I saw it looping with calls involvling Timer[35], which calls HealBot_CheckPlayerBuffs.

HealBot_CheckPlayerBuffs checks if people are in range I'm guessing by calling UnitIsVisible, which in my case is returning false, which resets Timer[35] back to true:

if UnitIsVisible(xUnit) then
HealBot_CheckPlayerUnitBuff[xUnit]=true
xButton.update.buff=true
xButton.status.update=true
else
HealBot_setOptions_Timer(35)
end

So to let other Timers have a chance I moved Timer[35] logic to almost the last elseif:

elseif HealBot_Options_Timer[7990] then
HealBot_Options_Timer[7990]=nil
HealBot_VersionUpdate_Spells() <--- this call got my attention so I wanted to move it after this, but generally wanted to move it towards the end

elseif HealBot_Options_Timer[35] then
--- LOOPING HERE
--HealBot_AddChat("got here 35");
HealBot_Options_Timer[35]=nil
HealBot_CheckPlayerBuffs()

elseif HealBot_Options_Timer[8000] then .....

Please Log in or Create an account to join the conversation.

3 months 4 weeks ago
Slayybelle
Regular Member
Regular Member
Posts: 31
More
Topic Author
Some non-healing abilities not working after spec change #1524
BTW it was also interfering with the Disable logic at Timer[501] which first got me looking at it.

Please Log in or Create an account to join the conversation.

3 months 4 weeks ago 3 months 4 weeks ago by Strife.
Strife
Administrator
Administrator
Posts: 718
Karma: 8
More
Some non-healing abilities not working after spec change #1527
Great, thanks for picking that up.
In the latest beta the nil is last so none of those timers can cause a loop, 35 looks like this
elseif HealBot_Options_Timer[35] then
    HealBot_CheckPlayerBuffs()
    HealBot_Options_Timer[35]=nil

UnitIsVisible is generally in visible range ~100 yards, UnitInRange and a few other api calls checks for in range of spells etc.
I will use a better way of dealing with units coming into visible range and requiring a buff.

Please Log in or Create an account to join the conversation.

Moderators: ctshammyAcirac