× Bug reports for the Retail version of Healbot

Target bar not in Targets Group (v8.0.1.8.bX)

1 year 8 months ago
Acirac's Avatar
Acirac
Moderator
Moderator
Posts: 18
More
Topic Author
Target bar not in Targets Group (v8.0.1.8.bX) #7
The issue appears to occur when enabling Combat Protection
Attachments:

Please Log in or Create an account to join the conversation.

1 year 8 months ago
Acirac's Avatar
Acirac
Moderator
Moderator
Posts: 18
More
Topic Author
Target bar not in Targets Group (v8.0.1.8.bX) #8
Looks like there is also an issue when enabling test bars:
14x HealBot\HealBot_Action.lua:3331: attempt to index field 'status' (a nil value)
HealBot\HealBot_Action.lua:3331: in function `HealBot_Action_SetTestButton'
HealBot\HealBot_Panel.lua:920: in function <HealBot\HealBot_Panel.lua:916>
HealBot\HealBot_Panel.lua:1008: in function <HealBot\HealBot_Panel.lua:943>
HealBot\HealBot_Panel.lua:2755: in function `HealBot_Panel_PartyChanged'
HealBot\HealBot_Action.lua:3397: in function `HealBot_Action_PartyChanged'
HealBot\HealBot-8.0.1.0.lua:806: in function <HealBot\HealBot.lua:803>
HealBot\HealBot-8.0.1.0.lua:3447: in function <HealBot\HealBot.lua:3421>
HealBot\HealBot-8.0.1.0.lua:4302: in function `HealBot_OnUpdate'
[string "*:OnUpdate"]:1: in function <[string "*:OnUpdate"]:1>

Locals:
hbCurFrame = 1
unitText = "Test Target 2"
thb = HealBot_Action_HealUnit7 {
 0 = <userdata>
 guid = "TestBar"
 id = 7
 frame = 1
 unit = "Test Target 2"
}
(*temporary) = nil
(*temporary) = 7
(*temporary) = 7
(*temporary) = "HealBot_Action_HealUnit7"
(*temporary) = "attempt to index field 'status' (a nil value)"
HealBot_Action_CreateButton = <function> defined @HealBot\HealBot_Action.lua:2692

Please Log in or Create an account to join the conversation.

1 year 8 months ago
Acirac's Avatar
Acirac
Moderator
Moderator
Posts: 18
More
Topic Author
Target bar not in Targets Group (v8.0.1.8.bX) #9
Fix for below issue, Change line 778 in HealBot_Action.lua
function HealBot_Action_HealthBar(button)
    if not button or not button["GetName"] then return nil end
    local barName = button:GetName();
    return _G[barName.."Bar"];
end

function HealBot_Action_HealthBar2(button)
    if not button or not button["GetName"] then return nil end
    local barName = button:GetName();
    return _G[barName.."Bar2"];
end

function HealBot_Action_HealthBar3(button)
    if not button or not button["GetName"] then return nil end
    local barName = button:GetName();
    return _G[barName.."Bar3"];
end

function HealBot_Action_HealthBar4(button)
    if not button or not button["GetName"] then return nil end
    local barName = button:GetName();
    return _G[barName.."Bar4"];
end

function HealBot_Action_HealthBar5(button)
    if not button or not button["GetName"] then return nil end
    local barName = button:GetName();
    return _G[barName.."Bar5"];
end

function HealBot_Action_HealthBar6(button)
    if not button or not button["GetName"] then return nil end
    local barName = button:GetName();
    return _G[barName.."Bar6"];
end

function HealBot_Action_HealthBarDir(button)
    if not button or not button["GetName"] then return nil end
    local barName = button:GetName();
    return _G[barName.."BarDir"];
end


Also getting the below error:
3x HealBot\HealBot_Action.lua:779: attempt to call method 'GetName' (a nil value)
HealBot\HealBot_Action.lua:779: in function `HealBot_Action_HealthBar'
HealBot\HealBot_Options.lua:11851: in function `HealBot_UpdateUsedMedia'
HealBot\HealBot_Options.lua:9663: in function <HealBot\HealBot_Options.lua:9663>
[C]: ?
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function `Fire'
...dMedia-3.0\LibSharedMedia-3.0\LibSharedMedia-3.0-6010002.lua:237: in function `Register'
MaxDps\Modules/custom.lua:16: in function <MaxDps\Modules/custom.lua:14>
(tail call): ?
MaxDps\core.lua:203: in function `InitRotations'
MaxDps\core.lua:146: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:119: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[C]: ?
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function `Fire'
Ace3\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals:
InCombatSkipped

Please Log in or Create an account to join the conversation.

1 year 8 months ago
Acirac's Avatar
Acirac
Moderator
Moderator
Posts: 18
More
Topic Author
Target bar not in Targets Group (v8.0.1.8.bX) #10
I have a fix for the test bars not working. The button attribs were not getting initialized for test bars, but are getting initialized for set heal buttons. I have pulled the initialization out into a separate function and am now calling it from both set heal bars and set test button. I will go ahead and create a merge request. I am going to also try and look into why the targets header is still not always showing even when combat protection is disabled.

Please Log in or Create an account to join the conversation.

1 year 8 months ago
Acirac's Avatar
Acirac
Moderator
Moderator
Posts: 18
More
Topic Author
Target bar not in Targets Group (v8.0.1.8.bX) #11
Getting the below error with beta 8

1x HealBot\HealBot_Options.lua:11851: attempt to call method 'GetName' (a nil value)
HealBot\HealBot_Options.lua:11851: in function `HealBot_UpdateUsedMedia'
HealBot\HealBot_Options.lua:9663: in function <HealBot\HealBot_Options.lua:9663>
[C]: ?
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function `Fire'
...dMedia-3.0\LibSharedMedia-3.0\LibSharedMedia-3.0-6010002.lua:237: in function `Register'
MaxDps\Modules/custom.lua:16: in function <MaxDps\Modules/custom.lua:14>
(tail call): ?
MaxDps\core.lua:203: in function `InitRotations'
MaxDps\core.lua:146: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:119: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[C]: ?
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function `Fire'
Ace3\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals:
InCombatSkipped
The following user(s) said Thank You Strife

Please Log in or Create an account to join the conversation.

1 year 8 months ago
Acirac's Avatar
Acirac
Moderator
Moderator
Posts: 18
More
Topic Author
Target bar not in Targets Group (v8.0.1.8.bX) #12
The fix for this in the latest version only checks the value of the function, not whether or not the function actually exists. To check if the actual function exists you need to use
if h["GetName"] then
                    local bar = _G[h:GetName().."Bar"]

Please Log in or Create an account to join the conversation.

Moderators: ctshammyAcirac